-
Notifications
You must be signed in to change notification settings - Fork 317
G65 - breadcrumbs position #4545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
During our last TF meeting, we agreed to update the examples by using aria-labelledby to reference the h2 titled "You are here". Honestly, I think this creates an unrealistic scenario, since breadcrumbs typically aren't visually labeled. The APG group, in fact, provides an example that uses aria-label instead: APG Breadcrumb Example. In my opinion, since this PR is addressing a different problem, we should open a separate issue to discuss this. Anyway, I believe the best approach would be to remove the visible label and follow the APG pattern. |
agree with @giacomo-petri here. let's keep this PR tightly focused on just some extra advice, and revisit the fundamental technique in general separately |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed on TF call 9/19/2025. Consensus with keeping this PR tightly focussed. Moved to Ready for Approval.
Closes #3891
Adding a sentence to recommend positioning the breadcrumb near the top of the page.
Deploy preview of G65 and diff: Providing a breadcrumb trail